Priority
Major
Type
Bug 
State
Fixed 
Assignee
Eugene Petrenko 
Subsystem
plugin: Thread dumps 
Affected versions
Fixed in
Fixed in build
Next build 
  • Submitted by   Yegor Yarko
    2 years ago (06 Nov 2007 10:20)
  • Updated by   Yegor Yarko
    2 years ago (19 Nov 2007 14:49)
  • Jira: TW-3750
    (history, comments)
TW-3750 XmlRpcException: NPE if cannot communicate with the agent
0
Trying to take thread dump:

Failed to communicate with agent unit-153 jetbrains.buildServer.xmlrpc.RemoteCallException: Call http://192.168.1.153:9090/RPC2 agent_stacktraces.dumpStacktracesToProcessCommandline: org.apache.xmlrpc.XmlRpcException: java.lang.Exception: java.lang.NumberFormatException: null

(agent had "No buffer space available" problem)

If there is an error, let's report it in a user-friendly way with some hints as to how to fix it.

Issue wasresolved
Comments (3)
 
History
  
Linked Issues (0)
 
Yegor Yarko
  Yegor Yarko
06 Nov 2007 11:44
(2 years ago)
let's:
  • tweak UI to make it more presentable
  • investigate if it is possible to determine there was no answer from agent to hide NumberFormatException in the case
Eugene Petrenko
  Eugene Petrenko
12 Nov 2007 21:38
(2 years ago)
Human readable messages are shown. Exception detail is posted to logs. Is that enough?
Yegor Yarko
  Yegor Yarko
15 Nov 2007 21:24
(2 years ago)
Current message is:
Failed to communicate with agent 'x64-unit-176 -Dtest="' (invalid response, see server logs for detais)

java.lang.RuntimeException: jetbrains.buildServer.xmlrpc.RemoteCallException: Call http://192.168.1.175:9090/RPC2 agent_stacktraces.dumpStacktracesToProcessCommandline: java.net.SocketException: Software caused connection abort: connect

Let's make the message shown in the browser more informative: currently, it says "invalid response", but it is "Software caused connection abort: connect" in fact. Let's ensure all the relevant information is included.

Let's also remove the "see server logs for detais" part as this is of almost no help to usual TYeamCity user, it can help only admins.
When removed, let's make sure the full stactrace is not dumped into the server log: let's dump it as debug message.
Can dump info message with the text like that shown in the web