Replace with Sytem.arraycopy produce wrong code : IDEA-46486

Back to Search

Project	IntelliJ IDEA
Priority	Normal
Type	Bug
Fix versions	No Fix versions
State	Fixed
Assignee	Bas Leijdekkers
Subsystem	Code Analysis. Inspection
Affected versions	No Affected versions
Fixed in build	108.65

Created by Boaz Nahum
3 years ago (03 Nov 2008 13:22)
Updated by root
2 years ago (17 Jan 2010 21:08)
Jira: IDEADEV-32398
(history, comments)

IDEA-46486 Replace with Sytem.arraycopy produce wrong code

Issue is visible to: All Users

This piece of code:

        for (int i = offset + offset2; i < length; i++) {
            destination[i] = source[i];
        }

Is replaced with:

        System.arraycopy(source, offset + offset2, destination, offset + offset2, length - offset + offset2);

The brackets around offset+offset2 are missing.
Should be:

        System.arraycopy(source, offset + offset2, destination, offset + offset2, length - (offset + offset2));

Thanks
Boaz

Environment: Windows XP

Issue was resolved

Boaz Nahum

03 Nov 2008 18:20

3 years ago

So, It won't be fix in Selena ?

Bas Leijdekkers

03 Nov 2008 18:29

3 years ago

I do not think there will be any more Selena releases. Currently this fix will not even go into the final release of Diana, because only the most critical bug fixes may go in now. Do you think this is a very important problem?